-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1pt] PR: Change Post proc perms updates #1238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Ran fim_pipeline.sh
on 3 HUCs: 03100204, 12040101, and 12090301. The time to reset permissions was greatly reduced from 8 seconds to 2 seconds.
On dev
Resetting Permissions
Duration = 0 min(s) and 8 sec
On dev-perm-reset
Resetting Permissions
Duration = 0 min(s) and 2 sec
In addition, since there's already a fix involving time, it might be a good chance to clean up one more thing. It looks like there's an extra message line that doesn't contain any information: Total Duration is ...
======================== End of fim_pipeline for dev ==========
Thu Aug 1 14:46:19 UTC 2024
Total Duration is ...
Duration : 59 min(s) and 33 sec
Ya.. I knew that one before. It is deceiving and will fix that quickly too. |
Tested changes, looks good. |
Prior to this fix, fim_post_processing.sh took just under 4 hours to reset permissions on all files and folder under the entire run. On closer inspection, it was updating permissions for all HUC folders where were already correct. A few other folders needed to have permission updates added. This will speed that up significantly.
Also, use this opportunity to added a new note to hash_compare.py and fix an annoying duration time showing milliseconds.
Changes
fim_pipeline.sh
: fix duration msgs.fim_post_processing.sh
: permissions reset fix, a bit of output cleanup and fix duration msgs.src
bash_functions.env
: update the Calc duration to allow for a msg prefix to be added to the duration calcs. Also adjusted the duration message to show hours as well, previously only min and seconds.run_by_branch.sh
: fix duration msgs.run_unit_wb.sh
: fix duration msgs.src\src_adjust_ras2fim_rating.py
: minor duration display msg change.tools\hash_compare.py
: Added noteTesting
To validate the correct format of output for the duratoin system, you can open docker and go to foss_fim, then run some commands straight in the console:
ie)
cd foss_fim
source src/bash_functions.env
start_time=
date +%s
adj_time=$(($start_time - (60 * 5)))
Calc_Duration "Duration testing : " $adj_time
adj_time=$(($start_time - (60 * 60 * 24)))
Calc_Duration "testing " $adj_time
Calc_Duration "testing " "Thu Aug 1 16:56:31 UTC 2024"
Also ran another small huc to validate all duration outputs.
Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)